Param for Max Retrial of Engine Cranking. #27926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peterbarker @tridge FYI |
loki077
force-pushed
the
Max-engine-cranking-retrial
branch
from
d4738d8
to
1bb4a94
Compare
robertlong13
suggested changes
Sep 3, 2024
robertlong13
force-pushed
the
Max-engine-cranking-retrial
branch
2 times, most recently
from
751c759
to
cc8154c
Compare
loki077
force-pushed
the
Max-engine-cranking-retrial
branch
from
cc8154c
to
fed7465
Compare
IamPete1
requested changes
Sep 23, 2024
robertlong13
force-pushed
the
Max-engine-cranking-retrial
branch
from
fed7465
to
64451a7
Compare
tridge
requested changes
Sep 24, 2024
Added Param MAX_RETRY which If set 0 or less, then there is no limit to retrials. If set to a value greater than 0 then the engine will retry starting the engine this many times before giving up.
robertlong13
force-pushed
the
Max-engine-cranking-retrial
branch
from
64451a7
to
eee6053
Compare
tridge
approved these changes
Sep 25, 2024
peterbarker
requested changes
Sep 25, 2024
| self.set_parameter("ICE_RPM_CHAN", 120) # Set to a non-existent sensor | ||
| self.set_rc(rc_engine_start_chan, 2000) | ||
| self.wait_statustext("Uncommanded engine stop") | ||
| self.wait_statustext("Starting engine") |
There was a problem hiding this comment.
check_context, similarly elsewhere in here
There was a problem hiding this comment.
Have to be careful here. I don't want
Starting engine
Engine running
Uncommanded engine stop
... [never starts again]
to pass, but if I check context on these, that would pass. I need to enforce an order. I expect to see
Starting engine
Engine running
Uncommanded engine stop
Starting engine
Engine running
Uncommanded engine stop
[... and so on and so forth]
There was a problem hiding this comment.
Looking at this again today, I think the test is good like it is currently; I got myself a little confused on the call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we use a common battery for Avionics and Engine Cranking we would like to have an option to limit the number of retrials so that it doesn't drain that battery completely. Obvious choice is to separate the batteries but I still think there could be some use of this feature.
My Implementation is by adding Param MAX_RETRY which If set 0 then there is no limit to retrials. If set to a value greater than 0 then the engine will retry starting the engine this many times before giving up. Also the counter to track retrials resets to zero on disarm (could be done only on power cycle rather than disarm). If needed to be override can be done by setting the param to 0.
I would like to get more ideas on the method of its implementation. I have not yest tested this code.
Other ways to implement this is by just keep increasing the time between retrials.